flow: synchronize thermal intensive cache - #7378
Open
akva2 wants to merge 1 commit into
Open
Conversation
akva2
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
Member
Author
|
jenkins build this failure_report please |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a state-consistency issue in the sequential implicit thermal (TEMP) workflow by ensuring intensive quantities are refreshed after the temperature solve, so cached temperature-dependent properties do not lag by one time level (notably affecting restart reproducibility).
Changes:
- After completing the sequential implicit temperature model timestep, invalidate and recompute intensive quantities for
timeIdx=0to synchronize caches with the updated temperature.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akva2
force-pushed
the
sync_temp_int_quants
branch
from
August 31, 2026 12:00
3044693 to
fd181ac
Compare
Member
Author
|
jenkins build this failure_report please |
Member
|
Does this make it possible to use finer or default tolerance for the following restarting case? add_test_compare_restarted_simulation(
CASENAME
spe1_temp
FILENAME
SPE1CASE2_TEMP
SIMULATOR
flow
DEV_SIMULATOR
flow_blackoil_temp
ABS_TOL
${abs_tol_restart}
REL_TOL
5.0e-2
RESTART_STEP
3
DIR
spe1
TEST_ARGS
--solver-max-time-step-in-days=1
)Maybe even the bigger time steps? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may possibly have been done on purpose, but it creates problem when restarting.
Currently, the intensive quantities are not updated after a new temperature has been solved by the sequential implicit temperature model. This means that the intensive quantities lag with one additional time level.
When doing restart, we rebuild the intensive quantities from primaries. The rebuilt intensive quantities do reflect the updated temperature, meaning we cannot reproduce the same simulator state after deserialization.