Skip to content

PD-6198 outlined icons #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cryptalith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PD-6198 outlined icons #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/cdk/interstitials/backup-email/interstitial-component/backup-email.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ <h2 class="orc-font-body" i18n="@@interstitial.yourPrimaryEmailAddress">
class="email-category"
*ngIf="primaryEmailCategory === 'PROFESSIONAL'"
>
<mat-icon class="material-icons-outlined">work</mat-icon>
<mat-icon class="material-symbols-outlined">work</mat-icon>
<span class="orc-font-small-print" i18n="@@interstitial.professional"
>Professional</span
>
</div>
<div class="email-category" *ngIf="primaryEmailCategory === 'PERSONAL'">
<mat-icon class="material-icons-outlined">fingerprint</mat-icon>
<mat-icon class="material-symbols-outlined">fingerprint</mat-icon>
<span class="orc-font-small-print" i18n="@@interstitial.personal"
>Personal</span
>
Expand Down
27 changes: 27 additions & 0 deletions src/app/cdk/interstitials/backup-email/interstitial-component/backup-email.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,33 @@ describe('BackupEmailComponent', () => {
expect(component.primaryEmailCategory).toBe('PROFESSIONAL')
})

// The outlined look comes from the Material Symbols font. The
// `material-icons-outlined` class these used to carry matches no loaded
// stylesheet, so it silently fell back to the filled font (PD-6198).
it('should draw the professional category icon in the outlined font', () => {
const icon = fixture.nativeElement.querySelector(
'.email-category mat-icon'
)

expect(icon.textContent.trim()).toBe('work')
expect(icon.classList).toContain('material-symbols-outlined')
})

it('should draw the personal category icon in the outlined font', () => {
emailCategory = () =>
of({ category: 'PERSONAL', rorId: null } as EmailCategoryEndpoint)

const newFixture = TestBed.createComponent(BackupEmailComponent)
newFixture.detectChanges()

const icon = newFixture.nativeElement.querySelector(
'.email-category mat-icon'
)

expect(icon.textContent.trim()).toBe('fingerprint')
expect(icon.classList).toContain('material-symbols-outlined')
})

it('should leave the category out when the lookup fails', () => {
emailCategory = () => throwError(() => new Error('lookup failed'))

Expand Down
Loading