PD-8720 mount the interstitial outlet before attaching it - #2920
Merged
Conversation
The already authorized OAuth path skips the authorization component, so none of the flags gating the card were set when the deferred showInterstitial() ran. The outlet lives inside that card, so the static:false ViewChild was never assigned and attachComponentPortal() threw, leaving the user with a blank page and no redirect to redirect_uri. Latent since a519d01 (PD-2371) gave the card an *ngIf; the setTimeout added back when the card was unconditional was no longer waiting for anything. showInterstitial() now mounts the card and runs a change detection pass before attaching, both in one synchronous block so the card is never painted empty, and falls back to the redirect if the outlet still cannot be resolved. The specs could not have caught this: the TestBed omitted PortalModule and every test either stubbed showInterstitial() out or hand-assigned an outlet.
Member
Author
amontenegro
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.