Cleanup output streams in GridKit core code - #599
Merged
Merged
Conversation
lukelowry
approved these changes
Oct 1, 2026
lukelowry
left a comment
Collaborator
There was a problem hiding this comment.
Very helpful thank you for the developer mode flag
Collaborator
|
Thanks for the much needed cleanup! What is the difference between |
Collaborator
Collaborator
Author
The difference is asserting that the target verbosity is higher than the previous one. We could use |
pelesh
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates most of the output streams in the
GridKitfolder to use the Logger instead ofstd::cout/std::cerr.Closes #512
Proposed changes
GRIDKIT_ENABLE_DEVELOPER_MODE, that currently increases the default verbosity. I envision using this for other purposes than verbosity levels.Logger::raiseVerbosityto prevent unintentionally lowering verbosity in applications and examples.std::cout/std::cerrcalls I think are worth keeping.std::endlwith"\n".std::cout/std::cerrthat only reported "tracing/debugging" information.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
We can either squeeze this in before #596 or defer to after the release.