Repository navigation
Fix BusToSignalAdapter evalJac bug - #603
Merged
Merged
Conversation
nkoukpaizan
approved these changes
Oct 5, 2026
nkoukpaizan
left a comment
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
We may remove this approach altogether after #602, but it doesn't hurt to fix.
BTW, @lukelowry What happened to the PR checklist?
Collaborator
Author
|
@nkoukpaizan I removed it I will add it back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BusToSignalAdapter::evaluateJacobian()leaves its COO Jacobian null, causing this warning during Enzyme system assembly:Assembly already skips the null contribution, so this is just a consistency change I found when experimenting with cosimulation.
Proposed changes
ConstantSignalSource.jacobian()test checking successful evaluation and a non-null matrix with zero entries.Further Comments
All tests pass