Repository navigation
Conversation
lukelowry
force-pushed
the
lukel/fault-improve-dev
branch
from
October 5, 2026 21:13
4d2335d to
6f2aebc
Compare
nkoukpaizan
self-requested a review
October 6, 2026 13:16
superwhiskers
left a comment
Collaborator
There was a problem hiding this comment.
this seems fine so far but it still needs BusFault to be removed entirely before it can be merged
Collaborator
Author
|
@pelesh Please advise the cutover is rather large. |
Collaborator
@superwhiskers, the idea for this PR is just to pilot proposed changes and show how the new implementation works. If this is approved, the follow up PR will make a wholesale transition to the new approach to bus faults and the old |
lukelowry
force-pushed
the
lukel/fault-improve-dev
branch
from
October 6, 2026 20:54
6f2aebc to
b6fe2d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Bus::setFaultto apply or clear a fault to ground directly at a bus. This is the first of two PRs. The follow-up removesBusFaultand changes solver fault events to name the bus.@pelesh Cleaned up
Proposed changes
BusBase::setFault(status, R, X). The default rejects the call, so aBusInfinitecannot be faulted.Bussubtracts the fault currentTenGenGenrouapplies its fault withsetFaultinstead of aBusFaultcomponent, and its reference check passes unchanged.Tests:
BusTests::faultchecks the fault current against its closed form, clearing the fault, and rejection of a zero impedance and of an infinite bus.BusTests::jacobianchecks the Jacobian against DependencyTracking and that clearing the fault leaves its entries in place at zero. 68/68 pass.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
BusFaultand the solver event format are unchanged here.