Repository navigation
BusFault Cleanup - #611
Merged
Merged
BusFault Cleanup#611
Conversation
nkoukpaizan
reviewed
Oct 8, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the well-scoped PR. I have a few comments, but otherwise looks good.
nkoukpaizan
approved these changes
Oct 8, 2026
Collaborator
Author
…lassical.cpp Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
lukelowry
force-pushed
the
lukel/busfault-removal-dev
branch
from
October 10, 2026 21:02
ada8b42 to
b06d99a
Compare
pelesh
approved these changes
Oct 13, 2026
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Well scoped and nicely executed PR.
The tolerance change in TenGen example is concerning; we need to investigate this further.
Given that key validation tests pass, I suggest we merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #607. Removes
BusFaultand usesBus::setFaultthroughout. Solver fault events now name the bus directly.Proposed changes
BusFault,getBusFault, and case-file fault definitions.bus, withRandXspecified forfault_on.ContingencyAnalysisfaults each bus in turn.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
None.