Skip to content

BusFault Cleanup - #611

Merged
pelesh merged 6 commits into
developfrom
lukel/busfault-removal-dev
Oct 13, 2026
Merged

pelesh merged 6 commits into
developfrom
lukel/busfault-removal-dev

Conversation

@lukelowry

Copy link
Copy Markdown
Collaborator

Description

Follow-up to #607. Removes BusFault and uses Bus::setFault throughout. Solver fault events now name the bus directly.

Proposed changes

  • Remove BusFault, getBusFault, and case-file fault definitions.
  • Solver events use bus, with R and X specified for fault_on.
  • ContingencyAnalysis faults each bus in turn.
  • Update examples, tests, plotting, and documentation.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • The CHANGELOG.md has been updated to reflect the changes.

Further comments

None.

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the well-scoped PR. I have a few comments, but otherwise looks good.

Comment thread tests/IntegrationTests/PhasorDynamics/TenGen/Classical/TenGenClassical.cpp Outdated
Comment thread application/PhasorDynamics/AnalysisUtilities.hpp
Comment thread application/PhasorDynamics/ContingencyAnalysis.cpp Outdated
Comment thread application/PhasorDynamics/DynamicSimulation.cpp Outdated
@lukelowry
lukelowry requested a review from nkoukpaizan October 8, 2026 18:44
Comment thread tests/IntegrationTests/PhasorDynamics/TenGen/Classical/TenGenClassical.cpp Outdated
Comment thread tests/IntegrationTests/PhasorDynamics/PDIntegrationTests.hpp Outdated
@lukelowry

Copy link
Copy Markdown
Collaborator Author

@pelesh @isatkaus Pending your review!

@lukelowry
lukelowry force-pushed the lukel/busfault-removal-dev branch from ada8b42 to b06d99a Compare October 10, 2026 21:02

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well scoped and nicely executed PR.

The tolerance change in TenGen example is concerning; we need to investigate this further.

Given that key validation tests pass, I suggest we merge this.

@pelesh
pelesh merged commit 2f0f4cb into develop Oct 13, 2026
6 checks passed
@lukelowry
lukelowry deleted the lukel/busfault-removal-dev branch October 13, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants