r.in.pdal: Add COPC support - #7213
Draft
cwhite911 wants to merge 4 commits into
Draft
Conversation
github-actions
Bot
added
raster
Contributor
|
I have #6465 open, see if there is some overlap. |
Contributor
Author
|
There is some overlap with accessing the CRS information that would make more sense as part of the other PR, but this PR is still addressing other issues. I will add a review with my suggested addition to PR #6465 |
When importing into a region smaller than the point cloud, pass the region bounds to readers.copc so its octree index skips nodes outside the region instead of decoding every point. Bounds are evaluated in the file's CRS, which is expected to match the project's CRS, so the pushdown is skipped when reprojection is requested. The GRASS spatial filter is kept for the exact per-point clip.
cwhite911
changed the title
Contributor
Author
github-actions
Bot
added
Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds COPC support to r.in.pdal.
execute(), so fall back to the reader stages. The -p file info output now prints the projection.readers.copcso the COPC spatial index skips data outside the region. The GRASS spatial filter still does the exact clip.GrassRasterWritermembers explicitly.base_segment_was previously uninitialized and read inprocessOne(), undefined behavior that could corrupt imported values when no base raster was given.