Tiny fixes - #3032
Open
dcermak wants to merge 3 commits into
Open
Conversation
schaefi
requested changes
Aug 10, 2026
| from typing import TypedDict # pragma: no cover | ||
| else: # pragma: no cover | ||
| from typing_extensions import TypedDict # pragma: no cover | ||
| from typing import Dict, List, Optional, TypedDict |
Collaborator
There was a problem hiding this comment.
If you want to remove use of typing_extensions can you do it also at the other places:
- bootloader/config/init.py
- builder/disk.py
- command.py
Thanks
Currently kiwi will by default load the runtime config files, but that has the disadvantage that the users config leaks into the test environment and breaks certain tests that assume that the default tool is `foo`, but the users settings say `bar`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.