feat: detect phantom dependencies#753
Open
goureeshreddy7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #731
What does this PR do? Implements the Phantom Dependency detection engine to catch unlisted imports that break strict environments like Vercel deployments (PD001 and PD002).
Key Changes:
AST Import Scanner: Upgraded scanProjectForPackageUsage in src/usage/scanner.ts to capture all bare module imports across the source code rather than just a pre-filtered list.
Overrides parsing: Added readOverridesAndResolutions to src/utils/package-json.ts to properly parse the overrides and resolutions blocks.
Cross-Referencing: Updated src/index.ts to cross-reference the import map against the declared dependencies.
Ranked Output: Output is ranked by build impact as requested, with strict deploy-breakers (PD001 - override pins) surfaced above standard transitive ghosts (PD002).
Testing: Verified locally that the CLI correctly catches ghost dependencies and exits with an error code, effectively stopping the build before deployment.