Skip to content

Optimize pcap reading for performance and low latency #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgodwin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize pcap reading for performance and low latency #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions port/rawlink/pcap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,26 @@ type PcapConfig struct {
}

// DefaultEtherTalkConfig returns a PcapConfig suitable for EtherTalk:
// promiscuous, immediate mode, 250ms read timeout.
// promiscuous, immediate mode, 1ms read timeout.
func DefaultEtherTalkConfig(iface string) PcapConfig {
return PcapConfig{
Interface: iface,
SnapLen: 65535,
Promiscuous: true,
ReadTimeout: 250 * time.Millisecond,
ReadTimeout: 1 * time.Millisecond,
ImmediateMode: true,
}
}

// DefaultMacIPConfig returns a PcapConfig suitable for MacIP:
// promiscuous, 100ms read timeout, no immediate mode required.
// promiscuous, 1ms read timeout, immediate mode enabled.
func DefaultMacIPConfig(iface string) PcapConfig {
return PcapConfig{
Interface: iface,
SnapLen: 65535,
Promiscuous: true,
ReadTimeout: 100 * time.Millisecond,
ImmediateMode: false,
ReadTimeout: 1 * time.Millisecond,
ImmediateMode: true,
}
}

Expand Down Expand Up @@ -141,7 +141,7 @@ func OpenPcapSimple(iface string, snapLen int, promisc bool, timeout time.Durati
// ReadFrame reads the next raw packet from the pcap handle.
// It returns ErrTimeout when the underlying libpcap read times out.
func (l *pcapLink) ReadFrame() ([]byte, error) {
data, _, err := l.handle.ReadPacketData()
data, _, err := l.handle.ZeroCopyReadPacketData()
if err != nil {
if err == pcap.NextErrorTimeoutExpired {
return nil, ErrTimeout
Expand Down
Loading