Conversation
Co-authored-by: pgodwin <1046558+pgodwin@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Carve forks/nextFork/byteLocks/maxLocks out of Service into a forkState
type with its own RWMutex. Fork I/O (Open/Close/Read/Write/Flush*/
GetForkParms/SetForkParms/ByteRangeLock) is the hottest AFP code path —
every active session touches it on every read or write — so isolating it
from auth, desktop, and volume traffic on a separate lock is the largest
contention win of the four substruct moves.
Helpers:
forks.register — installs a handle, returns new fork id
forks.get — RLock + map lookup; the hot Read/Write probe
forks.close — drops a fork id and evicts its byte-range locks
forks.snapshot — copy of all open handles for the volume-wide FPFlush
forks.lock — write-lock the whole struct (used by ByteRangeLock,
which needs atomicity across handle check + lock-list
scan + insertion)
maxReadSize stays on Service: it is set once at Start, read-only afterwards,
not actually fork state.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 participant
This commit scaffolds an end-to-end testing environment using minivmac, machfs python package, and a Go test coordinator. It includes basic AppleScript scaffolding, python scripts to build an 800K disk and extract results from it, and a go test wrapper that runs the full emulator flow headlessly using SDL2 dummy variables. Temporary
.dskfiles were appropriately.gitignored.PR created automatically by Jules for task 149906744981239180 started by @pgodwin