Move API content to the new toplevel API section, link the TopNav and light it up in the search - #3439
Conversation
7b870bb to
f64ede8
Compare
|
Pull request environment is available at https://stoctodocspr3439.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
|
|
||
| # updates to the octopus rest api tentacle exe command line page are reviewed by team-executions-foundations | ||
|
|
||
| /docs/octopus-rest-api/tentacle.exe-command-line/index.md @OctopusDeploy/team-executions-foundations |
There was a problem hiding this comment.
Did not think of this!! thanks for picking up on it
There was a problem hiding this comment.
I didn't either, just found it by accident in a global file search 😄
Nobody pays attention to these codeowners things, we could probably delete the whole file, but I took a more conservative approach
| "dev:watch": "onchange 'src/**/*.{js,mjs,ts,astro,css}' -- prettier --write --plugin=prettier-plugin-astro {{changed}}", | ||
| "astro": "astro", | ||
| "build": "astro build", | ||
| "build": "node --max-old-space-size=8192 node_modules/astro/bin/astro.mjs build", |
There was a problem hiding this comment.
They were intended (my machine kept crashing because the default nodejs 4gb) but on reflection it might be good to take them out.
enf0rc3
left a comment
There was a problem hiding this comment.
Looks good, i tested and confirmed the new url nav menu and also search that is filtering correctly.
There were some things on code-owners worth double checking as i think we moved some things.
Co-authored-by: William Laugesen <will.laugesen@gmail.com> Co-authored-by: Orion Edwards <orion.edwards@gmail.com>
Our new UI design intends for all the API-related docs to go under /docs/api, and be accessible via an "API" button in the top-level nav bar. The API docs also include generated docs, synced from the Octopus Server repository on a regular basis.
These generated docs were already present but not linked anywhere. This PR finishes the job, as follows
The top-nav "API" button now goes to
/docs/apiPages that were previously inside the
/docs/octopus-rest-apifolder have now moved to/docs/apiFixed all the links from
/docs/octopus-rest-api/**to now go to/docs/api/**Redirects have been installed for
/docs/octopus-rest-apiso external links pointing to the old URL's should still workThe "under construction" code has been removed, so the pagefind search index should now include generated API docs. Including change to the "Facet" thing
Reducing Risk
I've tested locally, but will re-test properly on the staging site (will check off as I've done)
apiHit some old
octopus-rest-api/links and check they redirect to the correct new URLdocs/octopus-rest-api/octopus.clientdocs/octopus-rest-api/examples/artifactsdocs/octopus-rest-api/openid-connectRedirects are annoying to test on the staging site as the redirects hardcode links to octopus.com/docs which won't be valid until this PR merges. But if you take the
/docs/api/...whateverpart of the URL from the redirect and check it on the staging site, it's goodPlease bash at it and do whatever you think might be worth testing