feat(openfoam): a response parameter may follow a swept value - #19
Merged
Merged
Conversation
OpenFOAM.Model 1.3.0: a response parameter's value may carry the study's
tokens (magUInf {{oc1}} beside the swept inlet speed) - the rules check
the value with each token standing for a number, and
FoamTemplating.CheckResponseCoverage refuses a response token the study
does not declare.
OpenFOAM 1.0.5: the node substitutes the variant's values into the
response parameters before it writes the function object, checks the
values again once they are real (a value that is not a plain dictionary
value is refused, never written), and names a token the variant gives no
value. A kit oracle runs pitzDaily twice with force coefficients on the
lower wall: the reference speed written as 10, then taken from the
variant as 20 - OpenFOAM reports exactly a quarter of the first Cd.
Sweep 2.0.4 carries the Model and checks the response tokens when the
study arrives, before any node sees it.
Why: a speed sweep with force coefficients normalised by a fixed magUInf
reports right coefficients at one speed only; the WitSweep app can now
pair the reference with the swept speed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A force-coefficient response normalises by its reference speed (
magUInf). When a study sweeps the inlet speed, a response that keepsmagUInf 20in every variant reports right coefficients at 20 m/s only. This lets a response parameter carry the study's tokens so the node gives it each variant's value.OpenFOAM.Model 1.3.0
FoamResponseRules: a parameter value may contain{{ocN}}tokens (each checked as a number until the variant supplies it).FoamTemplating.CheckResponseCoverage: a response token the study does not declare is a finding.OpenFOAM 1.0.5
FoamFunctionObjectWriter.Write(caseDirectory, request, substitutions)substitutes the variant's values into the response parameters, checks the real values with the same rules (a value that is not a plain dictionary value is refused and nothing is written), and names a token the variant gives no value.FoamCaseSessionpasses the task's substitutions.Sweep 2.0.4
Tests
🤖 Generated with Claude Code