feat(game-skin-admin): two-tier nav + unify KV schema to pieces - #28
Closed
joke-lx wants to merge 2 commits into
Closed
feat(game-skin-admin): two-tier nav + unify KV schema to pieces#28joke-lx wants to merge 2 commits into
joke-lx wants to merge 2 commits into
Conversation
deleteSkin 之前只移 KV index,文件资源保留 —— 与"删除"语义不一致,且长期累积 孤儿文件。现改为文件先删 + KV 后移:并发 DELETE 全部 pieces 与 boardBackground, 任一失败抛错中止(KV 不动);全部成功才移除 KV index。 replacePiece 同样会在 KV 持久化后 best-effort 清理被替换的旧 fileId(失败仅记 录,不影响主操作),避免每次换皮都留下一个孤儿文件。 UI 文案同步更新:删除 modal 描述移除"文件资源保留",按钮 tooltip 改为"联动删 除文件";替换 status 在新旧文件清状态之间给出三种文案分支。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename chess-skin-admin -> game-skin-admin (git mv, preserving history) and restructure per user's spec: - Two tabs at the top: Games | Emoji (Phase 3 emoji list stays as a stub EmojiListView until the emoji KV + Lua action pipeline lands). - Games tab: GameListView (card grid from GAME_SKIN_REGISTRY) -> click through to GameDetail (per-game admin with 3 tabs: preview | replace | upload). (?) store/restore scoped per detail entry; popstate sync keeps the ?game deep-link aligned. - Emoji tab: EmojiListView placeholder for common-<game> emoji packs (tag-prefix <gameId>-emoji), wired next phase. - Unified KV schema field name to pieces (was pieces|assets dual field + gameId==='chess' branches). fr/lib/core/game_kit/skin/game_skin_meta.dart always serializes/deserializes pieces; gomoku now uses the same field. Ve lint 0 errors; showcase vite build 31.72s green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #27: promote game-skin-admin two-tier nav that was not included in the first merge.
(per-game 3 tabs: preview | replace | upload) + deep-link ?game=.
unify KV schema field name to pieces (fr-aligned).