Repository navigation
fix(services): install nkeys for nats creds authentication - #69
Merged
Merged
Conversation
nats-py imports nkeys lazily when a creds file is used, so ingest and score crashed on connect with ModuleNotFoundError. Depend on nats-py[nkeys].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In release 0.1.0 corvus-ingest and corvus-score crash when connecting to NATS with a creds file:
ModuleNotFoundError: No module named 'nkeys'. nats-py importsnkeyslazily and only ships it as the optional extranats-py[nkeys].Fix
Depend on
nats-py[nkeys]inservices/pyproject.tomland regenerateservices/uv.lock(adds nkeys and pynacl). The Dockerfile usesuv sync --frozen, so the image picks it up. ml does not use NATS.Test
test_nkeys_package_is_installed_for_creds_file_authenticationassertsnkeysis importable. It fails without the extra and passes with it. ruff, ruff format and mypy are clean.