Skip to content

chore: replace SlenderBar BiConsumer with event-based state change system#75

Open
Joltras wants to merge 3 commits intomainfrom
feature/staminaChangeEvent
Open

chore: replace SlenderBar BiConsumer with event-based state change system#75
Joltras wants to merge 3 commits intomainfrom
feature/staminaChangeEvent

Conversation

@Joltras
Copy link
Copy Markdown
Collaborator

@Joltras Joltras commented Apr 27, 2026

Proposed changes

The current SlenderBar state notifier relies on a BiConsumer, which adds unnecessary complexity and requires callers to cast to the concrete type. This pull request replaces it with a StaminaChangeEvent to decouple the notification logic.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Joltras Joltras requested a review from TheMeinerLP April 27, 2026 13:24
@Joltras Joltras self-assigned this Apr 27, 2026
@Joltras Joltras added the area: game Everything related to the the game module label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant