Repository navigation
fix(party): keep a party alive after its other members leave - #27
Merged
Merged
Conversation
Contributor
Test results 171 files 171 suites 1m 20s ⏱️ Results for commit 5724817. ♻️ This comment has been updated with latest results. |
A leave or kick that leaves one member keeps the party open. The alone timeout counts from that departure, a join ends it, and the remaining member is told the party stays open. Zero remaining members still disband with last-member-left. Parties stored before this change have no alone-since time and keep expiring from their creation.
TheMeinerLP
force-pushed
the
fix/keep-party-alive
branch
from
October 30, 2026 19:37
ab00c73 to
5724817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
A player makes a party, a friend joins, and they play together for an hour. Then the friend's connection drops, or they step away to get food. The player who stayed gets the message that the party was disbanded because the last member left. When the friend comes back a few minutes later, there is no party to rejoin, so the player has to create one again and invite everyone again.
Now a party that loses its other members stays open. The player who is left gets a message that the friend left and that the party closes only if nobody joins for a while. The same rule applies when a leader kicks a member. The party's timer starts when the friend leaves. If someone joins, the timer stops. If the party is alone again later, the timer starts again from that moment. A party that loses its last member still closes right away.
The change follows the OpenSpec change
keep-parties-after-members-leave(proposal merged in #25).Types of changes
Checklist
Further comments
party.disbandedreasonlast-member-leftnow means that no member remained. Theexpired-alonelifetimes of parties that lost members are longer than before.