Repository navigation
docs: [SDK-5445] name the Codex MCP sign-in steps next to the Claude Code ones - #58
Conversation
|
Dogfood run on Oct 9 (local marketplace install of the stack branch, credentials skill in Codex) still ran |
…Code ones The credentials and verify skills told every user to run `/mcp` → onesignal → Authenticate, which is a Claude Code command. In Codex the steps are `codex mcp list`, `codex mcp login onesignal`, and `codex mcp add` when the server is absent. The README said the Codex plugin registers the MCP server from `.mcp.json`. That holds for the GitHub marketplace install only. The directory bundle ships no `.mcp.json`, so the README now gives the add-by-hand commands for that path.
…stall path The OpenAI directory listing attaches the OneSignal connector, so a Codex session from that install already has the OneSignal tools. The add-by-hand MCP step is now the fallback for a session with no tools at all, not the default for every directory install.
…eSignal MCP server `codex mcp login onesignal` and `codex mcp add` stop with an RFC 9207 origin error on Codex 0.161.0: the issuer is api.onesignal.com and the authorization endpoint is on dashboard.onesignal.com, and the server does not advertise issuer-bound callbacks. The README and the 2 skills no longer send the user into that error. They point at the connector (directory install) or the app API key path until the server changes.
Codex's own MCP sign-in fails against the OneSignal server today, so the README and the skills now name only the 2 paths that work: the OneSignal connector from the directory install, or the app API key.
A dogfood run with the earlier wording still ran codex mcp login onesignal and hit the OAuth origin error, then asked an open question. The skills now state the rule as an instruction before the options, drop the "codex mcp list shows Not logged in" cue that pointed at the command, and tell a Codex agent without the connector to ask with options 2 and 3 only.
a9270b6 to
47a7327
Compare
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Looks good. Credentials and verify agree on the Codex path: no codex mcp login, the connector when its tools are present, otherwise the key or dashboard options. Heads-up: #60 will conflict with this in the README Codex section; the resolution should keep this bullet.
One Line Summary
The credentials and verify skills now give the Codex MCP sign-in steps next to the Claude Code ones, and the README says which Codex install path registers the MCP server.
Motivation
We are looking to compare the MCP authentication experience in Codex and in Claude Code. The skills told every user to run
/mcp→ onesignal → Authenticate, which is a Claude Code command. A Codex user has no/mcpcommand and gets no usable instruction at the "No key and no MCP" gate.What I checked on Codex 0.161.0, from a clean
CODEX_HOMEand a local marketplace:.mcp.jsonin the plugin)/mcp→ onesignal → Authenticatecodex mcp listshowsonesignal … Not logged in.app.json,asdk_app_6a3d…,required: true);codex mcp listshows noonesignalserverThe directory bundle cannot ship
.mcp.json: the Skills upload rejects MCP configuration (seeAGENT.md, "The OpenAI directory bundle"). The live listing attaches the OneSignal ChatGPT app (asdk_app_6a3d…,required: true) through a portal-generated.app.jsoninstead. The bug bash screenshots confirm that a Codex app session from the directory install had the tools through that connector (the agent offered to upload "through the OneSignal connector"). I did not test the connector's sign-in prompt myself; my clean-CODEX_HOMEbundle install had no.app.json, which is whycodex mcp listwas empty there. The README describes the connector and keeps the add-by-hand commands as the fallback for a session with no OneSignal tools.Codex's own OAuth client rejects the OneSignal server. Reproduced in a scratch
CODEX_HOME:https://api.onesignal.com/.well-known/oauth-authorization-serverhasissuer: https://api.onesignal.comandauthorization_endpoint: https://dashboard.onesignal.com/oauth/authorize, and noauthorization_response_iss_parameter_supported. Codex'srmcp-client/src/oauth/issuer_binding.rsrejects that combination (RFC 9207). Same class as openai/codex#41677 and #41362. The fix is server-side: advertiseauthorization_response_iss_parameter_supported: trueand returnisson the callback, or serve the authorize endpoint onapi.onesignal.com. Until then the README and the skills do not namecodex mcp loginorcodex mcp addat all. They say: connector from the directory install, else the app API key. Server-side fix: SDK-5460 (auth-service,services/auth-http).Ticket: SDK-5445
Scope
skills/credentials/SKILL.md: the "No key and no MCP" ladder names the Codex check (codex mcp list) and the Codex sign-in step next to the Claude Code ones.skills/verify/SKILL.md: the same change in the "Tools absent" step.README.md, "Install in Codex → After install": Option A gets the tools through the OneSignal connector. Option B registers the server from.mcp.json, but Codex's sign-in fails against it with the error above, so the section says Codex's own sign-in does not work against it yet and names the 2 ways forward (Option A, orONESIGNAL_REST_API_KEY).Not changed: the packager, the manifests, the version (1.1.1 is already past the 1.1.0 release).
Testing
python3 scripts/package_directory_bundle.py --check: passesskills/andreferences/: no outputCODEX_HOME: installed the repository tree and the--outbundle through local marketplaces;codex mcp listoutput as in the table above;codex debug prompt-inputlistsonesignal:setup,onesignal:credentials, andonesignal:verifyfor both.codex mcp addandcodex mcp login onesignalin a scratchCODEX_HOME: both fail with the RFC 9207 error above before a browser opens.Not verified: a full skill run in Codex that reaches the "No key and no MCP" gate. The behavior evals did not run.
Affected code
README.md)Checklist
AGENT.mdpasscredentials_android_fcmandverify_gatestill to run before merge