Skip to content

feat: [SDK-5472] link to the test push on the dashboard in the verify report #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sherwinski merged 2 commits into from
Oct 12, 2026
Merged

feat: [SDK-5472] link to the test push on the dashboard in the verify report #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eeb159
feat: link to the test push on the dashboard in the verify report
sherwinski Oct 10, 2026
3de272d
fix: link the latest message after a resend in the verify report
sherwinski Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions skills/verify/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ Send to ONLY the subscription from step 2 — never a broadcast — and only aft
- **Fallback — REST:** `POST https://api.onesignal.com/notifications` with `Authorization: Key <KEY>`, body `{ "app_id": "<APP_ID>", "include_subscription_ids": ["<SUB_ID>"], "headings": { "en": "Successful test via OneSignal plugin" }, "contents": { "en": "<BODY>" } }`.
- **Unauthenticated create path:** an unauth path exists behind an app-level feature flag and is confirmed only for apps created via the AI integration flow — **UNVERIFIED for arbitrary apps.** Do NOT rely on it here. Default to the key-expression or MCP path. If the user has no key source and no MCP, follow the "No key → MCP first" order (see "Inputs you need") and wait for a working auth path rather than assert the unauth path will work.
- Capture the returned notification `id`. If the POST returns `errored` / an empty-recipients error, that itself is a finding → step 7.
- Build the dashboard link for this message from the App ID and that `id`: `https://dashboard.onesignal.com/apps/<APP_ID>/push/<NOTIFICATION_ID>`. Keep it for the final report. Both values are safe to show: the App ID is public, and the notification `id` is not a credential.

**Checkpoint** (telemetry contract rules apply, consent included): report the send outcome the moment the consent-and-create step resolves. This milestone records the create request, not the delivery — step 5 owns the delivery verdict. Run exactly one of:

Expand Down Expand Up @@ -203,6 +204,7 @@ State the activation ladder result explicitly — how far it climbed and where i
- Identity: verified / skipped (no `login()` call) / late-login flag.
- Test send: sent (notification id) / not sent (why).
- **Server-side: `successful=N` (ACTIVATED ✅) / failed / errored** — the headline result. `converted` and `received` reported only if observed, with the paid/SDK-only caveat on `received`.
- **Dashboard link** (only when step 4 returned a notification `id`): the message link from step 4, `https://dashboard.onesignal.com/apps/<APP_ID>/push/<NOTIFICATION_ID>`, as a clickable URL. After a step 7 §6 resend, link the latest message. Tell the user the page shows the delivery stats, the message content, and the clicks for this test push, and that the dashboard asks them to sign in first. Give the link on a win and on an `errored` result — the report page is where they see the failure detail too.
- Custom events: dashboard path given (not API-verified).
- If anything failed: the ranked cause, the skill to route to, and exact next step. Never claim success you did not observe server-side.

Expand Down
Loading