fix: require inspected citation regions - #149
Merged
Merged
Conversation
Force cited page images through visual inspection, preserve the resulting boxes through persistence and navigation, and avoid misleading full-page highlights. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Prevent cross-document region reuse and keep inspection enforcement and rendered overlays accurate. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm typecheckpnpm exec eslint e2e/citation-dedupe.e2e.ts src/app/e2e/citation-same-page/page.tsxPLAYWRIGHT_EXTERNAL_WEB_SERVER=1 pnpm exec playwright test e2e/citation-dedupe.e2e.ts --project=chromium(3 passed)pnpm testreached 765 passing tests with one suite-load timeout; the timed-out same-source citation test passed in isolationMade with Cursor