Skip to content

fix: recognize environment-prefixed session cookies - #150

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/environment-session-cookies
Aug 24, 2026
Merged

fix: recognize environment-prefixed session cookies#150
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/environment-session-cookies

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • recognize Better Auth session-token cookies with staging and production prefixes in Notebook's proxy
  • keep explicit cookie-name configuration additive while excluding non-token cookies such as session_data
  • prevent authenticated /inspect requests from redirecting to Dashboard login and producing secondary CORS errors

Test plan

  • pnpm exec vitest run src/proxy.test.ts src/infrastructure/auth/index.test.ts (29 passed)
  • pnpm typecheck
  • pnpm exec eslint src/proxy.ts src/proxy.test.ts src/infrastructure/auth/session-cookie-names.ts src/infrastructure/auth/index.ts src/infrastructure/auth/index.test.ts

Made with Cursor

Allow Notebook's proxy to recognize staging and production Better Auth token names so authenticated inspect requests are not redirected to login.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview Aug 24, 2026 1:28am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Aug 24, 2026 1:28am

Request Review

@suguanYang
suguanYang merged commit 245c1af into staging Aug 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant