Skip to content

fix: inspect materialized demo citation assets - #153

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/materialized-demo-image-inspection
Aug 24, 2026
Merged

fix: inspect materialized demo citation assets#153
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/materialized-demo-image-inspection

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • resolve materialized demo citation images through the canonical Knowhere demo asset endpoint
  • copy only cited demo images into durable Notebook Blob storage before VLM inspection
  • reuse the stored image on later inspections instead of retrying an unavailable parsed-sync asset

Test plan

  • pnpm exec vitest run src/domains/chat/route-service.test.ts src/agent-harness/runtime.test.ts
  • pnpm typecheck
  • pnpm exec eslint src/domains/chat/route-answer.ts src/domains/chat/route-service.test.ts
  • Full suite: 767 passed; six parallel timeout failures passed when rerun serially (33 tests)

Made with Cursor

Copy cited demo images into durable Notebook storage on demand so VLM inspection can succeed without a parsed-document sync.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview Aug 24, 2026 2:39am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Aug 24, 2026 2:39am

Request Review

@suguanYang
suguanYang merged commit beed226 into staging Aug 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant