Skip to content

Add catchall (improve #631)#648

Merged
oocube merged 2 commits into
masterfrom
addCatchall
May 21, 2026
Merged

Add catchall (improve #631)#648
oocube merged 2 commits into
masterfrom
addCatchall

Conversation

@oocube
Copy link
Copy Markdown
Contributor

@oocube oocube commented May 20, 2026

No description provided.

@oocube oocube requested review from mcarans and phkb as code owners May 20, 2026 19:37
Copy link
Copy Markdown
Contributor

@mcarans mcarans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably many of the developers listed under default owners are long time contributors to Oolite? If so, why not remove the separate shorter lists of developers for the folders? Then any change anywhere including workflows can be approved by any one of the devs who feels able to look at it.

Comment thread .github/CODEOWNERS
Copy link
Copy Markdown
Contributor

@phkb phkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in two minds with the requested change from @mcarans. Happy to go either way. It probably doesn't need resolution immediately, and given the current threat to CI/CD pipelines, tighter security is the better outcome.

@mcarans
Copy link
Copy Markdown
Contributor

mcarans commented May 20, 2026

Ok, let's go with it as is.

@oocube oocube merged commit 19fcb25 into master May 21, 2026
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants