Removed renaming of output (demand only)#58
Merged
Conversation
(tests/test_data/output/Green_Energy_Exports_RefYear2011_CNSW_POE10_OPSO_MODELLING.parquet -> tests/test_data/output/CNSW_RefYear_2011_HYDROGEN_EXPORT_POE10_OPSO_MODELLING.parquet)
…a for single file, rather than whole dict)
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
nick-gorman
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes functions that renamed the output file generated by the restructuring functions (but only for the demand trace data).
Background note
Renaming of the output parquet files is kind of unneccessary / not used since the release of V2 (which is when we moved to using the hive partitioning format). That is, the metadata contained in the renamed outputs isn't actually used / is a historical artifact of the previous approach (it also didn't hurt / didn't cause any problems to leave as is - so wasn't initially changed). It does introduce a pain point in migrating to the 2026 trace data, (and unnecessary to maintain) hence being actually removed now.
Summary
<input_stem>.parquetinstead of constructing a new filename from scenario/subregion/poe/demand_type metadata.write_new_demand_filenameandget_save_scenario_for_demand_traceremovedall_input_file_metadatalookup inside function).tests/test_data/output/Green_Energy_Exports_RefYear2011_CNSW_POE10_OPSO_MODELLING.parquet→tests/test_data/output/CNSW_RefYear_2011_HYDROGEN_EXPORT_POE10_OPSO_MODELLING.parquet