Repository navigation
feat: sync the libraries with OpenSysML develop (OpenSysMLRenderings, StateActivity, SysMLValidation, DocumentQueries) - #2
Merged
Conversation
…pen-MBEE/OpenSysML#816 The file is byte-identical to OpenSysML develop 155915e5a. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…en-MBEE/OpenSysML#871 The file is byte-identical to OpenSysML develop 42b54859f. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…SysML#886 The file is byte-identical to OpenSysML develop 42b54859f. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…pen-MBEE/OpenSysML#920 The file is byte-identical to OpenSysML develop 42b54859f. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…/OpenSysML#966 The file is byte-identical to OpenSysML develop 42b54859f. Co-Authored-By: jason.han <hanhuijun@gmail.com>
… both libraries Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
6 tasks done
HuiJun
marked this pull request as ready for review
October 9, 2026 22:17
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
libraries/back in line with OpenSysMLdevelop, which changed the vendored extension libraries after #1 was merged. Each file is copied byte-identically from OpenSysMLdevelop, in one commit per source PR:SysMLValidation.sysmlOpenSysMLRenderings.sysmlCaseView/asCaseDiagram,MixedView/asMixedDiagramDocumentQueries.sysmloverlay : String[0..1]attribute for requirement-diagram verdict overlaysStateActivity.kermlderived feature isActive : Boolean[1] featured by StateActiondiff -r libraries/against OpenSysML develop'sOpenSysML Libraries/shows no differences (16 files).Other changes:
engine-contract.jsongoes from 125 to 132 entries, all additions, socontractstays1:OpenSysMLRenderings(package) plus::CaseView,::MixedView,::asCaseDiagramand::asMixedDiagram, whichinternal/ir/view/view.gobinds by prefix.StateActivity(package) plus::isActive.overlayread targetsDocumentQueries::Diagram, which is adocumententry with no attribute list, so it needs no manifest change.CaseView/asCaseDiagramis described as a shorter way to write a standardGeneralViewfiltered on case-family metaclasses, with the standard route added by feat(view): render GeneralView requirement, definition, package and use case graphs OpenSysML#886.MixedView/asMixedDiagramis described as extension-only.StateActivityis listed as executing-engine.GeneralView,GridVieworInterconnectionViewwith a filter) expresses the same diagram.Not included: the four
standard library package→library packagefixes (Open-MBEE/OpenSysML#882) are still unmerged, so the 4-warning allow-list is unchanged.Verified locally:
validate-libraries.shgives 0 errors and exactly the 4 allow-listed warnings.check-engine-contract.shpasses.build-kpar.pybuilds an archive with 16 units.Open-MBEE/OpenSysML#881 pins this branch's head for now. Please merge this with a merge commit. After it merges I'll move that pin to the merge commit.
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/bf0cf4d7769a49a8adfee6bfd87860f3
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/bf0cf4d7769a49a8adfee6bfd87860f3?variant=devin
Requested by: @HuiJun