Repository navigation
feat(libraries): add MigrationMetadata::AppliedStereotype - #4
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
A migrated element may carry a source stereotype its v2 form does not keep: the element is itself the stereotype's form (a dependency for a «Trace»), or the stereotype comes from a profile the migration did not write. AppliedStereotype records the stereotype, the profile when it is not in the document, and the tag values no v2 feature holds, so tooling can still query them instead of reading a comment. The engine contract lists it as migrator-emitted; semver minor. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
The advisory job (
|
Contributor
Author
|
Superseded by #5, which landed the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one metadata definition to
MigrationMetadataand lists it in the engine contract. Semver: minor (new definition, no existing entry changed).The OpenSysML SysML v1 migrator stops writing stereotype kinds as package-level comments (
dependency A to B; /* «Trace» */), which CATIA Magic / Cameo renders as a Note on every diagram. The v2 element carries the kind in its name (dependency 'A traces B' from A to B) and, in non-strict output, annotates itself with@MigrationMetadata::AppliedStereotype { stereotype = "Trace"; }so tooling can still query the source stereotype.profileis set when the stereotype comes from a profile the migration did not write;tagskeeps, astag = value, the tag values no v2 feature holds.engine-contract.jsongains theMigrationMetadata::AppliedStereotypeentry (metadata, attributesstereotype/profile/tags,migratorEmitted, consumersinternal/translate/migrate/migrate.goandinternal/semantic/semantics/synthesized_name.go);contractstays at 1 since nothing existing changes. Open-MBEE/OpenSysML#1043 re-pins to this commit../scripts/validate-libraries.sh: 0 errors, 0 warnings;./scripts/check-engine-contract.shand./scripts/check-readme-table.shpass (the README row for MigrationMetadata is unchanged).Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/e836601d10af4cfcbdf98bc3321f53cd
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/e836601d10af4cfcbdf98bc3321f53cd?variant=devin
Requested by: @HuiJun