Repository navigation
feat(DocumentQueries): Diagram.show names the optional notation elements a document diagram draws - #6
Merged
Conversation
…nts a document diagram draws show lists, comma-separated, the notation elements a document diagram draws besides those its view's rendering shows: parameter-symbols, port-symbols, compartments, edge-labels, keywords, multiplicities, typings, qualifiers, or all. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
The required job ( |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one optional attribute to
DocumentQueries::Diagram, afterports:A document diagram's view rendering decides which notation elements are drawn by default;
showlets a document ask for more of them (or"all") without changing the view. Likeportsandoverlay, it is read by the document plan compiler that consumesDocumentQueries::Diagram; theengine-contract.jsonentry forDiagramlists no attributes, so the manifest is unchanged.Semver impact: MINOR (additive;
contractstays at 1).Checks:
./scripts/validate-libraries.sh(0 errors, 0 warnings),./scripts/check-engine-contract.sh --base origin/mainand./scripts/check-readme-table.shpass.Independent of #5; OpenSysML re-pins its vendored copy to
mainonce this merges.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/1927cf08c2b9400b8a4c522dde258549
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/1927cf08c2b9400b8a4c522dde258549?variant=devin
Requested by: @HuiJun