Repository navigation
chore(release): let the migrate race shard stay silent for an hour on CircleCI - #1066
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
go test buffers a package's -v output until it finishes, so a 55-minute package under a 30-minute no_output_timeout is killed for silence before it can pass. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Hotfix from
mainfor the 0.10.0 release, completing #1065. The first CircleCI build with the dedicatedmigraterace shard (develop 7969673) still failed:tests/migratealone on a 4-vCPUlargenode reachedpanic: test timed out after 30m0s(FAIL github.com/Open-MBEE/OpenSysML/tests/migrate 1800.088s), which is why #1065 gave that shard a 55-minutego test -timeout. But the step also hasno_output_timeout: 30m, andgo testprints a package's-voutput only once the package finishes (that node emitted its whole log in one chunk at the end), so a run between 30 and 55 minutes is killed by CircleCI for silence before it can pass. Thereleaseworkflow's publish jobs all requireGo race tests, so this is what stands betweenmainand a green rehearsal.go-race-test'sRun Go race testsstep:no_output_timeout30m → 60m, with the reason beside it (the repository already documents the same buffering for the REPL gate step).No test, flag or package change.
How it was verified
circleci config validate .circleci/config.ymlpasses.Go race testsnode 4 (shard migrate): 31.2 min, output delivered in a single chunk at the end,panic: test timed out after 30m0s. Locally the package alone takes 1423 s under-raceon 8 vCPU.release_rehearsalonmainafter merge; GitHub PR CI does not run this step.Checklist
make testandmake lintpass locally (CI configuration change; the Go suite is unchanged)changes/unreleased/<slug>.<section>.md(n/a: CI-only, no user-visible change; chore(release): give tests/migrate its own race shard so the 0.10.0 release workflow can pass #1065 already records the shard)make docs-countsrun if a gate count moved (n/a)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/3db6a090aa214667b2a66d372c6e36b1
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/3db6a090aa214667b2a66d372c6e36b1?variant=devin
Requested by: @HuiJun