Repository navigation
test(wasm): raise the engine and combined gzip budgets by 50 KB - #970
Merged
Merged
Conversation
develop at 4552bed (exact Rationals) is over the WebAssembly size budgets: the Go gates job measured the gzipped js build of sysml-wasm at 8,309,493 bytes against the 8,300,000-byte budget, failing TestWasmRuns/js/fits_the_combined_size_budget, and sysml-engine at 7,647,486 bytes, 2.5 KB under its 7,650,000-byte budget. Raise combinedGzipBudget to 8,350,000 and engineGzipBudget to 7,700,000 so both bound growth again. The engine figure is the one the existing changelog fragment for the dependency check already states. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
developat 4552bed (exact Rationals, #838) is over the WebAssembly size budgets. CircleCI'sGo gates and binariesjob on that commit measuredso
TestWasmRunsintests/wasmfails ondevelopitself and every branch containing #838 fails theWebAssembly gatecheck; the engine budget is ~2.5 KB from its own limit. Both budgets bound growth only (TestEngineDependenciescatches a forbidden dependency), so this lifts both by 50 KB in one round:tests/wasm/combined_test.go:combinedGzipBudget8,300,000 → 8,350,000tests/wasm/engine_test.go:engineGzipBudget7,650,000 → 7,700,000 — the figure the existingwasm-engine-dependency-check.changed.mdfragment already stateschanges/unreleased/wasm-size-budgets.changed.mddocs/andtests/wasmstate no budget figure (only measured sizes indocs/reference/wasm.md), so no doc or generated count moved.How it was verified
go test -count=1 -v -run 'TestWasmRuns' ./tests/wasmwith Node v24.19.0 and go1.25.11, so the js subtests ran rather than skipped.Before editing, on
origin/develop(2d1fc0f):This local build lands ~10–16 KB smaller than CircleCI's
cimg/go:1.25-nodebuild of the same tree (combined 8,293,016 vs 8,309,493; engine 7,637,664 vs 7,647,486), so the combined subtest passes here by 7 KB where CI fails it by 9 KB — the budgets are within toolchain noise either way, which is why both move at once.After editing:
Also:
go build ./...,go vet ./...,gofmt -l .(prints nothing),python3 scripts/changelog.py check.Checklist
go build ./...,go vet ./...,gofmt -l .and thetests/wasmgate pass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrunLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c5331dc511a342859cad8a88d46fa210
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c5331dc511a342859cad8a88d46fa210?variant=devin
Requested by: @HuiJun