Skip to content

run handlers for a client synchronously (async_handlers=False) #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReimarBauer merged 1 commit into from
Jul 18, 2026
+4 −0
Merged

run handlers for a client synchronously (async_handlers=False) #3137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mslib/mscolab/sockets_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,12 @@
from mslib.mscolab.utils import get_user_id
from mslib.mscolab.app import APP

# async_handlers=False handles each client's events in the order they were received. With
# the default (async_handlers=True) every event runs in its own thread, so two rapid
# file-save events can give a wrong final document data.
socketio = SocketIO(logger=APP.config['SOCKETIO_LOGGER'], engineio_logger=APP.config['ENGINEIO_LOGGER'],
async_mode='threading',
async_handlers=False,
cors_allowed_origins=("*" if not hasattr(APP, "CORS_ORIGINS") or
"*" in APP.config['CORS_ORIGINS'] else APP.config['CORS_ORIGINS']))

Expand Down
Loading