Skip to content

Deprecated code warnings #17

Description

@wernight

Affected Version(s): 1.0.8

PHP Version: 8.2 FPM

Webserver: Nginx

Browser: N/A

Description

Creation of dynamic property OwaSdk\Tracker\TrackerClient::$site_id is deprecated

Triggered from https://github.com/Open-Web-Analytics/owa-php-sdk/blob/master/src/Tracker/TrackerClient.php#L1236

How to reproduce

Just run the getting started sample code.

Possible Solution

Just declare $site_id member field (like the others) before assigning it.

Hotfix:

sed -i '/var $config;/a    var $site_id;' vendor/open-web-analytics/owa-php-sdk/src/Tracker/TrackerClient.php

Additional context

I see no recent update on this project for a few years, which I can understand, but wondering if you're still handling PR requests as I see some pending. Most of the fixes should be fairly trivial.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions