Can't disable backward incompatibility for a pattern change #845
Description
Activity
I do have a simple code fix to implement this, but I'm not sure what is the process to submit a PR for review.
Can you provide any pointers into how we could submit that? In the meantime we are using a local snapshot build to unblock our api spec development, but it's not ideal. I would love to see this integrated into the main codebase so we can rely on the official source of truth for openapi-diff
Sharing a patch with the content of my local commit to resolve this issue:
0001-fix-845-Proposed-solution-to-disable-BC-on-pattern-c.patch
I do have a simple code fix to implement this, but I'm not sure what is the process to submit a PR for review.
Can you provide any pointers into how we could submit that? In the meantime we are using a local snapshot build to unblock our api spec development, but it's not ideal. I would love to see this integrated into the main codebase so we can rely on the official source of truth for openapi-diff
Hello, thanks for collaboration, the process to provide PR is pretty common for all GitHub repos: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
@jdesrochers-atpco let me know if you did not manage to create a PR. Once changes will be merged I can create a next minor release for you ASAP.
@jdesrochers-atpco let me know if you did not manage to create a PR. Once changes will be merged I can create a next minor release for you ASAP.
Just needed to figure out how to work with public git repos... Submitted a PR for review:
#848Reacted by Aliaksandr PinchukThanks for reviewing my PR and merging it @DrSatyr . Let me know when a new release will be available so we can switch from our own internal snapshot build.
@jdesrochers-atpco release has been published #850. Thank you for your contribution.
Thanks for the quick turn-around time on this ; greatly appreciated @DrSatyr.
The latest 2.1.4 release is integrated in our pipeline automation and it works great.You are welcome! Nice to hear it.
When changing the regexp pattern of an existing property, there are no overrides available to explicitly skip the verification on pattern change.
Example:
previous schema
updated schema
Gives an
Schema: Broken compatibilityerror.This issue is to add a new config property (something like
incompatible.schema.pattern.changed) so we can disabled the pattern change rule.