Skip to content

hss_led: report an active disableLED lock in the radio LED status - #203

Merged
jens-maus merged 1 commit into
mainfrom
jens-maus/keen-mccarthy-iesppt
Oct 16, 2026
Merged

jens-maus merged 1 commit into
mainfrom
jens-maus/keen-mccarthy-iesppt

Conversation

@jens-maus

Copy link
Copy Markdown
Member

Summary

If /etc/config/disableLED exists ("LED-Nutzung (Funkmodul)" disabled in the WebUI), hss_led keeps the RPI-RF-MOD LED off. This also applies to manual overrides. hss_ledctl still answered OK accepted and status only showed an all-off pattern, so the LED looked broken. This is the most likely explanation for OpenCCU/OpenCCU#4443.

This PR makes the lock visible:

  • The --led rpi-rf-mod status reply now contains disabled=0|1, between pending= and pattern=:
    OK owner=auto backend=rgb pending=0 disabled=1 pattern=0 0 0 0
    
  • The hss_ledctl help text explains the meaning of disabled=1.
  • hss_led_state_test now checks the status reply both without and with disableLED.

LED behaviour is unchanged. disableLED still takes priority over all patterns, overrides included.

Testing

  • Built src/hss_led/tests/LedControllerTest.cpp with -Wall -Wextra -Werror -DLED_TEST_BUILD and ran it: PASS: 252 state/protocol/phase/backend assertions.

Refs: OpenCCU/OpenCCU#4443

🤖 Generated with Claude Code

https://claude.ai/code/session_01SbL2nitCeeQfAgCpgnq4SJ


Generated by Claude Code

With /etc/config/disableLED present the controller keeps the RPI-RF-MOD
LED off, manual overrides included, while hss_ledctl still acknowledges
commands and status only showed an all-off pattern. Add disabled=0|1 to
the rpi-rf-mod status reply so the lock is visible directly, and mention
it in the hss_ledctl help.

Refs: OpenCCU/OpenCCU#4443

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SbL2nitCeeQfAgCpgnq4SJ
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bd63aa45-f30e-4ef1-bc48-69c045316dbb
📥 Commits

Reviewing files that changed from the base of the PR and between 0b46b1a and a4e21e5.

📒 Files selected for processing: 2
  • src/hss_led/LedController.cpp
  • src/hss_led/tests/LedControllerTest.cpp
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus
jens-maus merged commit fb58999 into main Oct 16, 2026
5 checks passed
@jens-maus
jens-maus deleted the jens-maus/keen-mccarthy-iesppt branch October 16, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants