Repository navigation
hss_led: report an active disableLED lock in the radio LED status - #203
Merged
Merged
Conversation
With /etc/config/disableLED present the controller keeps the RPI-RF-MOD LED off, manual overrides included, while hss_ledctl still acknowledges commands and status only showed an all-off pattern. Add disabled=0|1 to the rpi-rf-mod status reply so the lock is visible directly, and mention it in the hss_ledctl help. Refs: OpenCCU/OpenCCU#4443 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SbL2nitCeeQfAgCpgnq4SJ
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
/etc/config/disableLEDexists ("LED-Nutzung (Funkmodul)" disabled in the WebUI), hss_led keeps the RPI-RF-MOD LED off. This also applies to manual overrides.hss_ledctlstill answeredOK acceptedandstatusonly showed an all-off pattern, so the LED looked broken. This is the most likely explanation for OpenCCU/OpenCCU#4443.This PR makes the lock visible:
--led rpi-rf-mod statusreply now containsdisabled=0|1, betweenpending=andpattern=:hss_ledctlhelp text explains the meaning ofdisabled=1.hss_led_state_testnow checks the status reply both without and withdisableLED.LED behaviour is unchanged.
disableLEDstill takes priority over all patterns, overrides included.Testing
src/hss_led/tests/LedControllerTest.cppwith-Wall -Wextra -Werror -DLED_TEST_BUILDand ran it:PASS: 252 state/protocol/phase/backend assertions.Refs: OpenCCU/OpenCCU#4443
🤖 Generated with Claude Code
https://claude.ai/code/session_01SbL2nitCeeQfAgCpgnq4SJ
Generated by Claude Code