Repository navigation
rfd: restore the channel AES policy when devices are republished - #211
Open
hobbyquaker wants to merge 1 commit into
Open
hobbyquaker wants to merge 1 commit into
hobbyquaker wants to merge 1 commit into
Conversation
After a coprocessor re-init (a LAN gateway reconnect, a module restart) republishAllDevices() re-adds every device and sets the user keys again, but not the per-channel authentication policy. The coprocessor starts with every channel off, so the events of a remote with AES active come in unauthenticated and rfd rejects them until the next restart or configuration write. Set the policy after a successful re-add with the values the interface keeps for the device, as the concentrator does after adding a device at start-up. Fixes OpenCCU#165
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hobbyquaker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a coprocessor re-init (a LAN gateway reconnect, a module restart) republishAllDevices() re-adds every device and sets the user keys again, but not the per-channel authentication policy. The coprocessor starts with every channel off, so the events of a remote with AES active come in unauthenticated and rfd rejects them until the next restart or configuration write.
Set the policy after a successful re-add with the values the interface keeps for the device, as the concentrator does after adding a device at start-up.
Fixes #165