Skip to content

session_start shouldn't be called in CLI context #24

Description

@tacman

I ran into an issue with a monitoring tool that checks all the routes. It is failing on the session check because it's calling session_start(), even though that won't work from the CLI.

Pierstoval/SmokeTesting#14

I think better would be to inject the RequestStack and get the session from there, and ignore the test if it fails or isn't available.

I realize that test is specifically about testing the session, and this is an edge case (calling the controller from a service that doesn't have a browser context).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions