chore: upgrade to PHP 8.5 - #349
Merged
Merged
Conversation
johanib
requested changes
Sep 8, 2026
Contributor
Author
|
Follow-up pushed in 17d698f. Summary: fixed the two reviewer-highlighted phpstan baseline entries by addressing the underlying source annotations, refreshed the baseline, scanned the remaining new suppressions and removed the safe/avoidable ones, clarified that Symfony 7 is out of scope for this PR, created follow-up issue #351 for that upgrade, and added CHANGELOG/README notes for the PHP 8.5 + Docker/Composer/npm refresh. |
phpmd MissingImport flagged inline \TypeError and \RuntimeException references introduced by the earlier baseline cleanup; add proper use statements and reference the short class names instead.
Pre-existing phpcs violations in InviteRole::requireOptionalString() and InviteRoleListFactory::requireString()/requireApplications() were masked by the earlier phpmd failure blocking the CI check script before phpcs ran. Auto-fixed via phpcbf now that phpmd passes.
kayjoosten
force-pushed
the
chore/php85-docker-composer-npm-update
branch
from
September 8, 2026 21:31
77d1b58 to
ae2a89c
Compare
johanib
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #344
Bumps Docker base images, Composer dependencies, and npm dependencies to PHP 8.5. Verified against the real CI Docker image, not just local host PHP.