Fix institution mismatch after saving vetting-type-hint - #532
Open
kayjoosten wants to merge 1 commit into
Open
Conversation
Redirect to the vetting-type-hint route with the saved institution on success, instead of re-rendering directly. Previously the select institution dropdown and page subtitle fell back to the RAA's home institution on POST, while the hint text shown was for the institution that was actually just edited, leaving the two out of sync. On save failure the form still re-renders in place so the submitted hints are not lost. Fixes #409
kayjoosten
commented
Sep 7, 2026
| } | ||
|
|
||
| $this->logger->debug('Vetting type hint saving failed, adding error to form'); | ||
| $this->addFlash('error', 'ra.vetting_type_hint.error'); |
Contributor
Author
There was a problem hiding this comment.
Make test and test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #409
Test plan
COMPOSER_MEMORY_LIMIT=1G composer check-cipasses.