chore: upgrade to PHP 8.5 - #535
Merged
Merged
Conversation
Bump PHP constraint to ^8.5, switch CI/Docker to the php85-apache2-node24 base images, and run Rector's PHP 8.3/8.4/8.5 rule sets. Skip NewMethodCallWithoutParenthesesRector since phpmd's PDepend parser can't yet handle that PHP 8.4 syntax. Also fixes two lingering phpstan/phpcs issues surfaced by the upgrade.
Bumps fast-uri, svgo, postcss, jscpd, less, and webpack to the versions proposed by dependabot PRs #527, #522, #525, and #518. All resolve within existing package.json semver ranges via yarn upgrade, so package.json is unchanged. jscpd's newer engine requirement is already satisfied by the php85-apache2-node24 CI image from the previous commit.
johanib
requested changes
Sep 10, 2026
johanib
left a comment
johanib
left a comment
Contributor
There was a problem hiding this comment.
Update changelog + update md.
Also check component_info if exists.
Then, 🟢 to merge.
kayjoosten
force-pushed
the
feature/issue-519-php85-rector
branch
2 times, most recently
from
September 14, 2026 10:34
8f47c41 to
a21db5e
Compare
- Add unreleased changelog entry for PHP 8.5/Node 24 upgrade - Bump component_info PHP_VERSION to 85 and NODE_VERSION to 24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #519
Bumps Docker base images, Composer dependencies, and yarn dependencies to PHP 8.5, plus Rector cleanup. Verified full CI gate (composer check-ci: phplint/phpmd/phpcs/jscpd/docheader/phpstan/phpunit) in the real ghcr.io/openconext/openconext-basecontainers/php85-apache2-node24 container. 85/85 tests passing, phpstan clean.