fix: fetch locked conformance harness history - #43
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes protected platform-evidence workflow runs by ensuring the conformance workflow checks out full git history so pinned/locked harness commits remain available after squash merges, and adds a regression guard to prevent reintroducing shallow checkouts.
Changes:
- Update
client-v1-conformanceworkflow checkout tofetch-depth: 0so locked harness revisions can be resolved. - Add a specification-guard test asserting the protected platform evidence workflow uses a full-history checkout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/specification-guards.test.ts |
Adds a regression guard test for full-history checkout in the protected evidence workflow. |
.github/workflows/client-v1-conformance.yml |
Sets fetch-depth: 0 on actions/checkout to ensure pinned harness commits are available. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+355
to
+361
| it('fetches the locked harness revision for protected platform evidence', () => { | ||
| const workflow = readText('.github/workflows/client-v1-conformance.yml'); | ||
|
|
||
| expect(workflow).toMatch( | ||
| /actions\/checkout@[0-9a-f]{40}\n {8}with:\n {10}fetch-depth: 0\n {10}persist-credentials: false\n {10}ref: \$\{\{ github\.sha \}\}/u, | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failure addressed
Protected run 33325765303 failed on all three platforms with
phase1.stage.runner-checkout.failedbecause the default depth-1 checkout contained only the squash merge commit, whilephase1-conformance.lock.jsoncorrectly pins the reviewed pre-pin harness commit.Validation
fetch-depth: 0Advances OpenCoven/sdk#38.