fix: redact runtime-reported memory activity before audit - #86
Merged
Conversation
Signed-off-by: Codex <codex@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the worker’s result sanitization to ensure runtime-reported memory activity (SessionResult.memory_used) is scrubbed for live tokens and token-shaped strings before any downstream persistence or publication, preventing secrets from being exposed via audit/inspection surfaces.
Changes:
- Extend
sanitize_resultto traversememory_used.read,memory_used.proposed, andmemory_used.rejected, redacting all containedStringfields. - Expand the existing redaction regression test to populate
memory_usedwith representative read/proposed/rejected entries and assert token removal from the serialized result.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SessionResult.memory_used, allowing runtime-supplied memory read ids and proposed write keys (which may contain live tokens) to be persisted and returned by the memory inspection API, creating a high-severity secret exposure risk.Description
sanitize_resultto traverse and redact all strings insideSessionResult.memory_used, includingMemoryEntryRef.id/scope,ProposedMemory.key/summary/scope/approval, andRejectedMemoryfields, before any validation, persistence, or publication. (Seecrates/worker/src/redact.rs.)memory_usedwith read, proposed, and rejected entries and assert that live tokens are removed from the serialized result. (Test lives in theredacttests incrates/worker.)Testing
cargo test -p coven-github-worker redact::tests::sanitize_result_scrubs_every_free_text_fieldand the test passed.cargo check --all-targetsandcargo clippy --all-targets -- -D warnings, both completing successfully.cargo test --all; repository-wide unit tests completed but some worker integration tests failed due to the local test environment returning403 Forbiddento mocked HTTP requests (these failures are environmental and not caused by the redaction change).Codex Task