fix(specimens): restore a coherent responsive browser shell - #1
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Restores the specimens app “browser shell” UI/UX (top bar, navigation rail, catalog hierarchy, density control, and assembled lab framing) and extends the contract verifier to assert these shell behaviors post-migration, without changing @opencoven/ui exported component contracts.
Changes:
- Rebuilds the specimens shell layout (sticky top bar, rail navigation, grouped catalog, explicit density control, empty-search state).
- Refactors specimen styling to restore hierarchy/rhythm, add responsive rail behavior, and remove decorative gradients.
- Expands
scripts/verify-contracts.mjswith new assertions covering shell landmarks, hierarchy, density control, responsive nav, and “no gradients”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
scripts/verify-contracts.mjs |
Adds contract assertions for the specimens shell structure, hierarchy, density control, responsive rail behavior, and gradient avoidance. |
apps/specimens/src/specimens.css |
Replaces the previous minimal styling with a full shell + catalog + responsive layout stylesheet and reduced-motion/forced-colors handling. |
apps/specimens/src/app.tsx |
Rebuilds the specimens app shell (top bar/rail/main), groups specimens into sections, adds an explicit density control, and reframes /lab as an assembled workbench. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Recover the specimen browser’s visual hierarchy after the React/package migration while preserving the public
@opencoven/uiAPI and keeping Cave as production UI authority.What changed
/labinto a framed assembled workbench using exported blockscomponentsversusblocksimport pathSessionHeader,TranscriptTurn, and tabsDeliberate non-goals
Verification
Final head:
36c2b6371b664a5453fd143dd224ba12f667c897CI— successpnpm check— passFinal file set
.github/workflows/ci.ymlapps/specimens/src/app.tsxapps/specimens/src/main.tsxapps/specimens/src/specimens-fixes.cssapps/specimens/src/specimens.csspackages/ui/src/blocks/session-header.tsxpackages/ui/src/blocks/transcript-turn.tsxpackages/ui/src/components/ui/tabs.tsxpackages/ui/tests/mobile-blocks.test.tsxpackages/ui/tests/tabs.test.tsxpublic/r/session-header.jsonpublic/r/tabs.jsonpublic/r/transcript-turn.jsonscripts/verify-contracts.mjsRisk and rollback
The shell work is isolated to the specimen app. Exported block changes are additive responsive corrections with matching generated registry payloads; no prop or export contract changes are introduced. Revert this PR to restore the preceding presentation and compositions.