Skip to content

Update rolling workflow msrv#37

Merged
jerrysxie merged 2 commits into
OpenDevicePartnership:mainfrom
kurtjd:rolling-msrv
May 14, 2026
Merged

Update rolling workflow msrv#37
jerrysxie merged 2 commits into
OpenDevicePartnership:mainfrom
kurtjd:rolling-msrv

Conversation

@kurtjd
Copy link
Copy Markdown
Contributor

@kurtjd kurtjd commented May 14, 2026

The msrv was recently updated, but the rolling workflow was accidentally not bumped up. This PR just fixes that.

Resolves #36

@kurtjd kurtjd self-assigned this May 14, 2026
Copilot AI review requested due to automatic review settings May 14, 2026 15:44
@kurtjd kurtjd requested a review from a team as a code owner May 14, 2026 15:44
@kurtjd kurtjd requested a review from benonivainqueur May 14, 2026 15:44
@kurtjd kurtjd moved this to In review in ODP Backlog May 14, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the MSRV used by the rolling CI workflow from 1.85 to 1.90 to match the recently updated MSRV in Cargo.toml and .github/workflows/check.yml. The lengthy comment that documented the rationale for prior MSRV bumps is removed alongside the version change.

Changes:

  • Update msrv matrix entry in the rolling workflow from "1.85" to "1.90".
  • Remove the historical inline comment explaining previous MSRV constraints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jerrysxie jerrysxie enabled auto-merge (squash) May 14, 2026 16:01
@jerrysxie jerrysxie removed the request for review from benonivainqueur May 14, 2026 16:01
@jerrysxie jerrysxie disabled auto-merge May 14, 2026 16:37
@jerrysxie jerrysxie merged commit 47805aa into OpenDevicePartnership:main May 14, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in ODP Backlog May 14, 2026
@kurtjd kurtjd deleted the rolling-msrv branch May 14, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rolling workflow failure

3 participants