v4: Cartesian OKLab matcher, sRGB-space ordered dither, flat API#29
Merged
Conversation
- Rust: dither() now takes a DitherConfig struct with Default impl, replacing the 6-positional-arg signature. Pre-processing pipeline expands to expose exposure, saturation, shadows, and highlights as orthogonal knobs. - Python: dither_image() arguments are now keyword-only after color_scheme. Renames tone_compression→tone and gamut_compression→gamut. Adds exposure, saturation, shadows, highlights kwargs. - JavaScript: ditherImage() takes an options object instead of positional args. Mirrors Python's API. Exports DitherOptions type. - FFI: PyO3 and WASM bindings collapse into a single dither_image function that accepts either scheme_id or palette_bytes. Removes the previous scheme/palette split. Co-located changes: - Adds apply_exposure / adjust_saturation / apply_shadows_highlights and oklab_to_rgb to enable the new knobs. - All test suites updated for the new API; 39 Rust + 74 Python + 31 JS tests pass. BREAKING CHANGE: positional args replaced with kwargs/options/config struct. Callers must update. See README for migration guide.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three landed changes from the
rustdevelopment branch:match_pixel_oklabusesdist² = dL² + Wab²·(da² + db²)withWab=1.5(empirically validated against the regression fixture set).ordered_dither_activity_is_perceptually_uniform): linear-space ratio ≈ 13.5 vs sRGB-space ≈ 4.3 across mid-tone bands.DitherConfigstruct withDefault; Python forces keyword-only args aftercolor_scheme; JavaScript uses an options object. Addsexposure,saturation,shadows,highlightsas orthogonal pre-dither knobs alongside the existingtoneandgamut.Test plan
Closes #27 #28.