Conversation
boring-cyborg
Bot
added
Compiler
ZeWaka
commented
Sep 11, 2026
| } | ||
|
|
||
| /// <returns>The 1-indexed position of the value, or 0 if it isn't in the [start, end) range</returns> | ||
| protected static int FindValueInSpan<T>(ReadOnlySpan<T> values, T value, int start, int end) where T : IEquatable<T> { |
Collaborator
Author
There was a problem hiding this comment.
only used a handful of times but figured it was best to abstract this out
|
|
||
| /// <summary> | ||
| /// Turns Find()'s Start/End into a [start, end) range of 1-indexed positions. | ||
| /// End 0 is just past the last element, Start 0 is 1, a negative Start finds nothing. |
Collaborator
Author
There was a problem hiding this comment.
unsure if negative start should also be a ListFindOutOfBoundsException
| if (!value.TryGetValueAsDreamObject<DreamObjectAtom>(out var atom)) | ||
| return 0; | ||
|
|
||
| return _visContents.IndexOf(atom, start - 1, end - start) + 1; |
Collaborator
Author
There was a problem hiding this comment.
indexof is 0-indexed
ZeWaka
marked this pull request as ready for review
September 11, 2026 06:38
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also implemented
DreamGlobalVars.GetLength()since my enumeration stuff needs it and it was missingtested pretty thoroughly in the DM tests, only ones not covered are the 3 client ones (verbs, screen, images)
fixes #2302