Skip to content

Drop SoftReservedKeyword to warning by default #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wixoaGit merged 2 commits into from
Sep 16, 2026
+10 −1
Merged

Drop SoftReservedKeyword to warning by default #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6db7e9
Drop `SoftReservedKeyword` to `warning` by default
Sep 13, 2026
2fb89f9
fix tests
Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Content.Tests/DMProject/Tests/Arg/SoftReservedKeyword1.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
//COMPILE ERROR OD2000
// NOBYOND

#pragma SoftReservedKeyword error

var/src = 321

/proc/RunTest()
Expand Down
3 changes: 3 additions & 0 deletions Content.Tests/DMProject/Tests/Arg/SoftReservedKeyword2.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
//COMPILE ERROR OD2000
// NOBYOND

#pragma SoftReservedKeyword error

/proc/test(args)
return 1

Expand Down
3 changes: 3 additions & 0 deletions Content.Tests/DMProject/Tests/Arg/SoftReservedKeyword3.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
//COMPILE ERROR OD2000
// NOBYOND

#pragma SoftReservedKeyword error

/proc/RunTest()
var/usr = 123
world.log << "fail"
Expand Down
2 changes: 1 addition & 1 deletion DMCompiler/Compiler/CompilerError.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public struct CompilerEmission {
{WarningCode.ErrorRecoveryActivated, ErrorLevel.Error},

//2000-2999
{WarningCode.SoftReservedKeyword, ErrorLevel.Error},
{WarningCode.SoftReservedKeyword, ErrorLevel.Warning},
{WarningCode.ScopeOperandNamedType, ErrorLevel.Warning},
{WarningCode.DuplicateVariable, ErrorLevel.Warning},
{WarningCode.DuplicateProcDefinition, ErrorLevel.Error},
Expand Down
Loading