SoilDyn: Remove flag SlDNonLinearForcePortionOnly#3322
Merged
andrew-platt merged 5 commits intoOpenFAST:devfrom Apr 30, 2026
Merged
Conversation
andrew-platt
approved these changes
Apr 30, 2026
Collaborator
|
I see we have a SoilDyn driver, but no test cases for it. I'll look through my development test cases and see if there is one I can repurpose for testing here. I'll add it as a separate PR if I find it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
As noted in PR #3319, the
SlDNonLinearForcePortionOnlyflag was previously hardcoded to TRUE and had no functional effect. This PR removes that legacy flag from the SoilDyn code to improve clarity.The updated logic is straightforward:
CalcOption= 1 or 3) is always passed to and included in SubDyn.The
SlDNonLinearflag is now exclusively used whenCalcOption= 3 (REDWIN) and it affects only reaction load outputs in SubDyn (sensor-written values, not physical behavior).Impacted areas of the software
SoilDyn.
Test results, if applicable
No changes expected.