Repository navigation
InnerLayer.SLAYER - DOCS - 🌱 Describe chi_tor as the toroidal momentum diffusivity, not a heat diffusivity - #471
Merged
Conversation
…diffusivity, not a heat diffusivity Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d-burg
force-pushed
the
docs/slayer-chi-tor-momentum-diffusivity
branch
from
October 28, 2026 15:58
b2d00c8 to
f968890
Compare
d-burg
marked this pull request as ready for review
October 28, 2026 21:53
matt-pharr
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
Two docstrings still called
chi_tora heat diffusivity. They now describe it as χ_φ, the toroidal momentum diffusivity, which sets the momentum Prandtl number P_tor = τ_R/τ_φ with τ_φ = r_s²/χ_φ (Fitzpatrick, Phys. Plasmas 30, 092512 (2023)). Docstrings only.Changes
build_slayer_inputs(LayerInputs.jl):chi_toris the toroidal momentum diffusivity, not a "toroidal heat diffusivity".LayerParameters.jl): theP_torrow reads τ_R/τ_φ with τ_φ = r_s²/χ_φ, instead of the undefined τ_‖tor.Regression report
regress --cases diiid_slayer_n1 --refs 057c4af0d,f9688909c --forceon feynman (SLURM, 8 threads; develop vs this head, both fresh, manifest pinned): every quantity unchanged. The docs build passes.diiid_slayer_n1Notes for reviewers
slayer_parametersandSLAYERControldocstrings that this PR originally changed, so the branch was rebuilt from develop057c4af0dwith only the two lines InnerLayer.SLAYER - FEATURE! - Build P_perp from the perpendicular particle diffusivity by default and add an ion heat diffusivity profile #501 left. The previous head is kept onbackup/471-pre-rebuild-b2d00c886.🤖 Generated with Claude Code