Skip to content

InnerLayer.SLAYER - DOCS - 🌱 Describe chi_tor as the toroidal momentum diffusivity, not a heat diffusivity - #471

Merged
matt-pharr merged 1 commit into
developfrom
docs/slayer-chi-tor-momentum-diffusivity
Oct 28, 2026
Merged

matt-pharr merged 1 commit into
developfrom
docs/slayer-chi-tor-momentum-diffusivity

Conversation

@d-burg

@d-burg d-burg commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Release note

  • Audience: users
  • Numerical impact: none (harness @ f968890)
  • Migration: none

Two docstrings still called chi_tor a heat diffusivity. They now describe it as χ_φ, the toroidal momentum diffusivity, which sets the momentum Prandtl number P_tor = τ_R/τ_φ with τ_φ = r_s²/χ_φ (Fitzpatrick, Phys. Plasmas 30, 092512 (2023)). Docstrings only.

Changes

  • build_slayer_inputs (LayerInputs.jl): chi_tor is the toroidal momentum diffusivity, not a "toroidal heat diffusivity".
  • SLAYER parameter table (LayerParameters.jl): the P_tor row reads τ_R/τ_φ with τ_φ = r_s²/χ_φ, instead of the undefined τ_‖tor.

Regression report

regress --cases diiid_slayer_n1 --refs 057c4af0d,f9688909c --force on feynman (SLURM, 8 threads; develop vs this head, both fresh, manifest pinned): every quantity unchanged. The docs build passes.

diiid_slayer_n1
Regression Report: diiid_slayer_n1
=========================================================================
Ref 1: 057c4af0d  @ 057c4af0d (2026-10-28)
       env: julia 1.11.9, x86_64-linux-gnu, manifest 3136d36b (pinned), 8 threads/8 BLAS, jit build
Ref 2: f9688909c  @ f9688909c (2026-10-28)
       env: julia 1.11.9, x86_64-linux-gnu, manifest 3136d36b (pinned), 8 threads/8 BLAS, jit build
-------------------------------------------------------------------------
Quantity                            057c4af0d  f9688909c  Diff     Status
-------------------------------------------------------------------------
SLAYER surface indices              [6 elem]   [6 elem]   0.0e+00  OK
SLAYER poloidal m                   [6 elem]   [6 elem]   0.0e+00  OK
SLAYER toroidal n                   [6 elem]   [6 elem]   0.0e+00  OK
SLAYER minor radius rs              [6 elem]   [6 elem]   0.0e+00  OK
SLAYER r-based shear                [6 elem]   [6 elem]   0.0e+00  OK
SLAYER Lundquist S                  [6 elem]   [6 elem]   0.0e+00  OK
SLAYER D_norm                       [6 elem]   [6 elem]   0.0e+00  OK
SLAYER P_perp                       [6 elem]   [6 elem]   0.0e+00  OK
SLAYER tauk                         [6 elem]   [6 elem]   0.0e+00  OK
SLAYER iota_e                       [6 elem]   [6 elem]   0.0e+00  OK
SLAYER Q_e                          [6 elem]   [6 elem]   0.0e+00  OK
SLAYER Q_i                          [6 elem]   [6 elem]   0.0e+00  OK
SLAYER Q_root [2/1,3/1,4/1]         [3 elem]   [3 elem]   0.0e+00  OK
SLAYER ω_Hz [2/1,3/1,4/1]           [3 elem]   [3 elem]   0.0e+00  OK
SLAYER γ_Hz [2/1,3/1,4/1]           [3 elem]   [3 elem]   0.0e+00  OK
SLAYER no_root flags [2/1,3/1,4/1]  [3 elem]   [3 elem]   0.0e+00  OK
SLAYER enabled flag                 1          1          0.0e+00  OK
Runtime (s)                         293.1s     284.0s              --
=========================================================================
Summary: 17 unchanged

Notes for reviewers


🤖 Generated with Claude Code

@github-actions github-actions Bot added the docs Documentation only label Sep 25, 2026
@d-burg d-burg changed the title InnerLayer.SLAYER - DOCS - Describe chi_tor as the toroidal momentum diffusivity, not a heat diffusivity InnerLayer.SLAYER - DOCS - 🌱 Describe chi_tor as the toroidal momentum diffusivity, not a heat diffusivity Oct 5, 2026
…diffusivity, not a heat diffusivity

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@d-burg
d-burg force-pushed the docs/slayer-chi-tor-momentum-diffusivity branch from b2d00c8 to f968890 Compare October 28, 2026 15:58
@d-burg d-burg added this to the GPEC v2.0.0 milestone Oct 28, 2026
@d-burg
d-burg requested a review from matt-pharr October 28, 2026 19:29
@d-burg d-burg self-assigned this Oct 28, 2026
@d-burg
d-burg marked this pull request as ready for review October 28, 2026 21:53
@matt-pharr
matt-pharr merged commit 1fc2349 into develop Oct 28, 2026
16 of 17 checks passed
@matt-pharr
matt-pharr deleted the docs/slayer-chi-tor-momentum-diffusivity branch October 28, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants