Repository navigation
PerturbedEquilibrium - DOCS - Identify the surface displacement and correct Glasser citations - #540
Merged
Conversation
krystophny
force-pushed
the
docs/xi-s-surface-displacement-20261019
branch
from
October 26, 2026 17:01
9c1ca15 to
8abdfa6
Compare
krystophny
marked this pull request as ready for review
October 26, 2026 17:02
Collaborator
Author
|
Rebased onto develop 23ff553 and marked ready with a reviewer requested; the release note now carries the harness stamp the convention check requires. Chris&AI |
Collaborator
|
@krystophny I disagree with the inclusion of any symbolic scripts in this repo, that is not what this repo is for. Beyond that, I do not understand the purpose of the derivation of a conversion from pmodb to boozer/hamada gauges that is not implemented in the code here. I do agree with and appreciate the correction of article numbers. What does Chris sans AI think? |
Collaborator
Author
|
@matt-pharr Chris sans AI is sorry that this slipped through. I remove it. |
…orrect Glasser citations
krystophny
force-pushed
the
docs/xi-s-surface-displacement-20261019
branch
from
October 27, 2026 17:20
8abdfa6 to
9552d66
Compare
krystophny
changed the title
matt-pharr
approved these changes
Oct 28, 2026
matt-pharr
left a comment
matt-pharr
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the correction and the quick response!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify
xi_sas the surface displacement defined by Glasser (2016), Eqs. 9 and 18, and correct the two swapped Glasser article identifiers.Release note
Regression report
Full documentation build and targeted internal-docstring render passed. Native
solovev_n1: all 22 tracked quantities unchanged.Notes for reviewers
The formatter also normalized three existing lines in the touched Julia file.
Chris&AI