Repository navigation
KineticForces - BUGFIX! - Keep the small collision width positive for either rotation sign - #561
Merged
Conversation
github-actions
Bot
added
bugfix
krystophny
marked this pull request as ready for review
October 23, 2026 09:06
krystophny
added a commit
to krystophny/GPEC.jl
that referenced
this pull request
Oct 23, 2026
…n precession reverses The "small" collision operator used nu = 1e-5*we, so a negative omega_E gave a negative Krook width and turned damping into anti-damping. Use 1e-5*|we|, as in Fortran GPEC PR 320, and test the operator against a Krook operator of that width for both rotation signs. Upstream-PR: OpenFUSIONToolkit#561 Cherry-picked-from: 643f362
krystophny
added a commit
to krystophny/GPEC.jl
that referenced
this pull request
Oct 23, 2026
…n precession reverses (#5) The "small" collision operator used nu = 1e-5*we, so a negative omega_E gave a negative Krook width and turned damping into anti-damping. Use 1e-5*|we|, as in Fortran GPEC PR 320, and test the operator against a Krook operator of that width for both rotation signs. Upstream-PR: OpenFUSIONToolkit#561 Cherry-picked-from: 643f362
… either rotation sign
krystophny
force-pushed
the
bugfix/small-collision-abs-we-20261023
branch
from
October 27, 2026 17:20
643f362 to
77ef6d1
Compare
krystophny
changed the title
matt-pharr
approved these changes
Oct 28, 2026
matt-pharr
left a comment
matt-pharr
left a comment
Collaborator
There was a problem hiding this comment.
Matches the fortran correction reviewed by @logan-nc. Code is fine. @krystophny FYI we typically prefer that the regression harness output is posted in the PR body so exactly what changed is precisely enumerated. Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
1e-5 * abs(we)fornutype = "small"so negative rotation does not reverse the collision width, matching the Fortran correction.Release note
nutype = "small"at negative rotation (harness @ 77ef6d1)Regression report
KineticForces tests: 5,097 assertions pass; the added test fails at all three negative-rotation points without the fix. Native
solovev_kinetic_ntv: all seven tracked quantities unchanged.Notes for reviewers
The regression test compares the energy integrand with an equivalent positive Krook width at both rotation signs.
Chris&AI
Generated by Claude Code